Super_Hippo wrote...
Add it to the Block class.
Nooooob wrote ...
2017/3/9
Need help
Got it. No errors anymore but the blocks are still not falling or forming the tetromino shapes.
I think you have to post the whole code again to see how everything looks right now.
Super_Hippo wrote...
I think you have to post the whole code again to see how everything looks right now.private Block[] tetromino = new Block[4];
int[][]line = {{1,1,1,1},
{0,0,0,0},
{0,0,0,0},
{0,0,0,0}};
int[][]thunder = {{1,1,0,0},
{0,0,1,1},
{0,0,0,0},
{0,0,0,0}};
int[][]pyramid = {{0,1,0,0},
{1,1,1,0},
{0,0,0,0},
{0,0,0,0}};
public MyWorld()
{
super(15, 20, 40);
addObject(new Block(), 10, 2);
}
public void create()
{
if (!moveTetromino(1))
{
moveTetromino(-1);
int[][][] layouts = { line, thunder, pyramid };
int[][] layout = layouts[Greenfoot.getRandomNumber(layouts.length)];
int x = Greenfoot.getRandomNumber(15);
int y = Greenfoot.getRandomNumber(3);
createTetromino(layout, x, y);
if (!moveTetromino(0)) gameOver();
}
}
public void createTetromino(int[][] layout, int x, int y)
{
int counter = 0;
for (int a=0; a <4; a++) for (int b=0; b<4; b++)
{
if (layout[a][b] == 1)
{
tetromino[counter++] = new Block();
addObject(tetromino[counter], x+b, y+a);
}
}
}
private boolean moveTetromino(int dir)
{
{
boolean result = true;
for (Block block : tetromino) result = result && block.fall(dir);
return result;
}
}
private void gameOver()
{
Greenfoot.stop();
}public boolean fall(int dir)
{
setLocation(getX(), getY()+dir);
return getObjectsAtOffset(0, 0, Block.class).isEmpty();
}
Try to change line 20 to:
and line 24 to:
If you wouldn't pass anything to the createTetromino method and make the random things in the method, you would only need to make the first change (and change it to createTetromino instead).
create();
if (tetromino[0]==null || !moveTetromino(1))
Super_Hippo wrote...
Try to change line 20 to:
create();
if (tetromino[0]==null || !moveTetromino(1))
Oh yes, that was pretty obvious...
Okay, try this:
public void createTetromino()
{
int[][][] layouts = { line, thunder, pyramid };
int[][] layout = layouts[Greenfoot.getRandomNumber(layouts.length)];
int x = Greenfoot.getRandomNumber(15);
int y = Greenfoot.getRandomNumber(3);
//everything which is in the createTetromino method right now goes here
}public void create()
{
if (!moveTetromino(1))
{
moveTetromino(-1);
createTetromino();
if (!moveTetromino(0)) gameOver();
}
}public MyWorld()
{
super(15, 20, 40);
createTetromino();
}
Try this there:
if (layout[a][b] == 1)
{
tetromino[counter] = new Block();
addObject(tetromino[counter], x+b, y+a);
counter++;
}Super_Hippo wrote...
Try this there:
if (layout[a][b] == 1)
{
tetromino[counter] = new Block();
addObject(tetromino[counter], x+b, y+a);
counter++;
}Change
to
public void create()
public void act()
Super_Hippo wrote...
Change
public void create()
public void act()
I think the problem is that the blocks in the tetromino are blocked by the other blocks in the tetromino when falling.
Doesn't really look optimal, but test this for now.
private boolean moveTetromino(int dir)
{
boolean result = true;
for (Block block : tetromino) block.fall(dir);
for (Block block : tetromino) result = result && block.fall(0);
return result;
}
I think the problem is in the 'fall' method I provided. Evidently, when using 'getObjectsAtOffset', if the calling object is of the type given, it is included in the list. Therefore, line 4 of the method should be:
My apologies.
return getObjectsAtOffset(0, 0, Block.class).size() == 1;
Still, if you move and check intersection for each block alone, it can move upon another block of this tetromino.
There are more replies on the next page.