Timer Done

Yehuda

2017/4/20

Sometimes when I click on the pauseButton I get the message saying "Timer Done", right after I clicked on the button. I made it that the least amount of time the timer can be set to is 1 minute so why is the window popping up right when I click on it. Even worse is it happens but not very often, so I have no idea what all the times that it happens have in common. What can I do to stop the Timer Done window from popping up at the wrong times.

import greenfoot.World;
import greenfoot.core.WorldHandler;

import java.awt.Color;
import java.awt.Dimension;
import java.awt.Font;
import java.awt.GridBagConstraints;
import java.awt.GridBagLayout;
import java.awt.Insets;
import java.awt.Toolkit;
import java.awt.event.ActionEvent;
import java.awt.event.ActionListener;

import java.text.DecimalFormat;

import java.util.Calendar;

import javax.swing.DefaultListModel;
import javax.swing.JButton;
import javax.swing.JLabel;
import javax.swing.JList;
import javax.swing.JOptionPane;
import javax.swing.JPanel;
import javax.swing.JScrollPane;
import javax.swing.JSpinner;
import javax.swing.JTabbedPane;
import javax.swing.SpinnerNumberModel;
import javax.swing.SwingConstants;
import javax.swing.Timer;
import javax.swing.UIManager;
import javax.swing.UnsupportedLookAndFeelException;
import javax.swing.event.ChangeEvent;
import javax.swing.event.ChangeListener;

/**
 * Write a description of class ClockWorld here.
 *
 * @author Yehuda
 * @version 4/19/2017
 */
public class ClockWorld extends World {

    JPanel worldPanel;

    JTabbedPane clockPane = new JTabbedPane();
    JPanel clockPanel = new JPanel();
    JPanel stopwatchPanel = new JPanel();
    JPanel timerPanel = new JPanel();

    JLabel clockLabel = new JLabel();
    JLabel dayLabel = new JLabel();
    JLabel dateLabel = new JLabel();
    Timer clockTimer;

    static final String[] dayString = new String[]{"", "Sunday", "Monday", "Tuesday", "Wednesday", "Thursday", "Friday", "Saturday"};
    static final String[] monthString = new String[]{"January", "February", "March", "April", "May", "June", "July", "August", "September", "October", "November", "December", "Undecimber"};
    static final String[] ampmString = new String[]{"AM", "PM"};

    JButton startButton = new JButton();
    JButton lapButton = new JButton();
    JLabel stopwatchElapsedLabel = new JLabel();
    Timer stopwatchTimer;
    long stopwatchStartTime;
    long stopwatchPausedTime;
    int stopwatchElapsedTime;
    int stopwatchHours;
    int stopwatchMinutes;
    int stopwatchSeconds;
    int stopwatchHundreds;
    JScrollPane lapScrollPane = new JScrollPane();
    JList lapList = new JList();
    DefaultListModel lapListModel = new DefaultListModel();

    JLabel hourLabel = new JLabel();
    JLabel minuteLabel = new JLabel();
    JSpinner hourSpinner = new JSpinner();
    JSpinner minuteSpinner = new JSpinner();
    int hourValue = 0;
    int minuteValue = 0;
    JButton pauseButton = new JButton();
    JButton cancelButton = new JButton();
    JLabel timerLabel = new JLabel();
    Timer timerTimer;
    long timerStartTime = 0;
    long timerPausedTime = 0;
    int timerElapsedTime = 00;
    int timerHours = 00;
    int timerMinutes = 00;
    int timerSeconds = 00;
    int timerHundreds = 00;

    DecimalFormat numberFormat = new DecimalFormat("00");

    /**
     * Constructor for objects of class ClockWorld.
     *
     */
    public ClockWorld() {
        // Create a new world with 200x260 cells with a cell size of 1x1 pixels.
        super(200, 260, 1);

        worldPanel = WorldHandler.getInstance().getWorldCanvas();
        try {
            // Set System L&F
            UIManager.setLookAndFeel(UIManager.getSystemLookAndFeelClassName());
        } catch (UnsupportedLookAndFeelException | ClassNotFoundException | InstantiationException | IllegalAccessException e) {
            // handle exception
        }
        GridBagConstraints gridConstraints = new GridBagConstraints();
        clockPane.setPreferredSize(new Dimension(200, 250));
        gridConstraints.gridx = 0;
        gridConstraints.gridy = 0;
        worldPanel.add(clockPane, gridConstraints);

        // clock panel
        clockPanel.setLayout(new GridBagLayout());
        clockPanel.setBackground(Color.BLACK);

        dayLabel.setText("");
        dayLabel.setFont(new Font("Arial", Font.PLAIN, 16));
        dayLabel.setForeground(Color.WHITE);
        dayLabel.setBackground(Color.BLACK);
        gridConstraints = new GridBagConstraints();
        gridConstraints.gridx = 0;
        gridConstraints.gridy = 0;
        gridConstraints.insets = new Insets(0, 0, 5, 0);
        clockPanel.add(dayLabel, gridConstraints);

        dateLabel.setText("");
        dateLabel.setFont(new Font("Arial", Font.PLAIN, 16));
        dateLabel.setForeground(Color.WHITE);
        dateLabel.setBackground(Color.BLACK);
        gridConstraints = new GridBagConstraints();
        gridConstraints.gridx = 0;
        gridConstraints.gridy = 1;
        gridConstraints.insets = new Insets(5, 0, 5, 0);
        clockPanel.add(dateLabel, gridConstraints);

        clockLabel.setText("");
        clockLabel.setFont(new Font("Arial", Font.PLAIN, 16));
        clockLabel.setForeground(Color.WHITE);
        clockLabel.setBackground(Color.BLACK);
        gridConstraints = new GridBagConstraints();
        gridConstraints.gridx = 0;
        gridConstraints.gridy = 2;
        gridConstraints.insets = new Insets(5, 0, 0, 0);
        clockPanel.add(clockLabel, gridConstraints);
        clockTimerActionPerformed(null);

        clockPane.add("Date - Time", clockPanel);

        // stopwatch panel
        stopwatchPanel.setLayout(new GridBagLayout());

        stopwatchElapsedLabel.setText("00:00:00.00");
        stopwatchElapsedLabel.setFont(new Font("Arial", Font.PLAIN, 20));
        gridConstraints = new GridBagConstraints();
        gridConstraints.gridx = 0;
        gridConstraints.gridy = 0;
        gridConstraints.gridwidth = 2;
        gridConstraints.insets = new Insets(0, 0, 5, 0);
        stopwatchPanel.add(stopwatchElapsedLabel, gridConstraints);

        startButton.setText("Start");
        startButton.setOpaque(true);
        startButton.setFocusPainted(false);
        startButton.setForeground(new Color(0, 200, 0, 255));
        startButton.setBackground(new Color(0, 128, 0, 255));
        gridConstraints = new GridBagConstraints();
        gridConstraints.gridx = 1;
        gridConstraints.gridy = 1;
        gridConstraints.anchor = GridBagConstraints.CENTER;
        gridConstraints.insets = new Insets(5, 5, 0, 0);
        stopwatchPanel.add(startButton, gridConstraints);
        startButton.addActionListener(new ActionListener() {
            public void actionPerformed(ActionEvent e) {
                startButtonActionPerformed(e);
            }
        });

        lapButton.setText("Lap");
        lapButton.setEnabled(false);
        lapButton.setFocusPainted(false);
        gridConstraints = new GridBagConstraints();
        gridConstraints.gridx = 0;
        gridConstraints.gridy = 1;
        gridConstraints.anchor = GridBagConstraints.CENTER;
        gridConstraints.insets = new Insets(5, 0, 0, 5);
        stopwatchPanel.add(lapButton, gridConstraints);
        lapButton.addActionListener(new ActionListener() {
            public void actionPerformed(ActionEvent e) {
                lapButtonActionPerformed(e);
            }
        });

        lapScrollPane.setPreferredSize(new Dimension(150, 100));
        lapScrollPane.setViewportView(lapList);
        lapList.setFont(new Font("Arial", Font.PLAIN, 12));
        gridConstraints = new GridBagConstraints();
        gridConstraints.gridx = 0;
        gridConstraints.gridy = 2;
        gridConstraints.gridwidth = 2;
        gridConstraints.insets = new Insets(10, 0, 0, 0);
        stopwatchPanel.add(lapScrollPane, gridConstraints);

        clockPane.add("Stopwatch", stopwatchPanel);

        // timer panel
        timerPanel.setLayout(new GridBagLayout());

        timerLabel.setText("00:00.00");
        timerLabel.setVisible(false);
        timerLabel.setFont(new Font("Arial", Font.PLAIN, 25));
        gridConstraints = new GridBagConstraints();
        gridConstraints.gridx = 0;
        gridConstraints.gridy = 0;
        gridConstraints.gridwidth = 4;
        gridConstraints.anchor = GridBagConstraints.CENTER;
        gridConstraints.insets = new Insets(0, 0, 5, 0);
        timerPanel.add(timerLabel, gridConstraints);

        hourSpinner.setModel(new SpinnerNumberModel(0, 0, 23, 1));
        hourSpinner.setVisible(true);
        ((JSpinner.DefaultEditor) hourSpinner.getEditor()).getTextField().setHorizontalAlignment(SwingConstants.CENTER);
        ((JSpinner.DefaultEditor) hourSpinner.getEditor()).getTextField().setEditable(false);
        gridConstraints = new GridBagConstraints();
        gridConstraints.gridx = 0;
        gridConstraints.gridy = 0;
        gridConstraints.anchor = GridBagConstraints.CENTER;
        gridConstraints.insets = new Insets(0, 0, 5, 5);
        timerPanel.add(hourSpinner, gridConstraints);
        hourSpinner.addChangeListener(new ChangeListener() {
            public void stateChanged(ChangeEvent e) {
                spinnerStateChanged(e);
            }
        });

        hourLabel.setText("hours");
        hourLabel.setVisible(true);
        gridConstraints = new GridBagConstraints();
        gridConstraints.gridx = 1;
        gridConstraints.gridy = 0;
        gridConstraints.anchor = GridBagConstraints.CENTER;
        gridConstraints.insets = new Insets(0, 0, 5, 5);
        timerPanel.add(hourLabel, gridConstraints);

        minuteSpinner.setModel(new SpinnerNumberModel(1, -1, 60, 1));
        minuteSpinner.setVisible(true);
        ((JSpinner.DefaultEditor) minuteSpinner.getEditor()).getTextField().setHorizontalAlignment(SwingConstants.CENTER);
        ((JSpinner.DefaultEditor) minuteSpinner.getEditor()).getTextField().setEditable(false);
        gridConstraints = new GridBagConstraints();
        gridConstraints.gridx = 2;
        gridConstraints.gridy = 0;
        gridConstraints.anchor = GridBagConstraints.CENTER;
        gridConstraints.insets = new Insets(0, 5, 5, 5);
        timerPanel.add(minuteSpinner, gridConstraints);
        minuteSpinner.addChangeListener(new ChangeListener() {
            public void stateChanged(ChangeEvent e) {
                spinnerStateChanged(e);
            }
        });

        minuteLabel.setText("min");
        minuteLabel.setVisible(true);
        gridConstraints = new GridBagConstraints();
        gridConstraints.gridx = 3;
        gridConstraints.gridy = 0;
        gridConstraints.anchor = GridBagConstraints.CENTER;
        gridConstraints.insets = new Insets(0, 0, 5, 0);
        timerPanel.add(minuteLabel, gridConstraints);

        cancelButton.setText("Cancel");
        cancelButton.setEnabled(false);
        cancelButton.setFocusPainted(false);
        gridConstraints = new GridBagConstraints();
        gridConstraints.gridx = 0;
        gridConstraints.gridy = 1;
        gridConstraints.gridwidth = 2;
        gridConstraints.insets = new Insets(5, 0, 0, 5);
        gridConstraints.anchor = GridBagConstraints.CENTER;
        timerPanel.add(cancelButton, gridConstraints);
        cancelButton.addActionListener(new ActionListener() {
            public void actionPerformed(ActionEvent e) {
                cancelButtonActionPerformed(e);
            }
        });

        pauseButton.setText("Start");
        pauseButton.setForeground(new Color(0, 200, 0, 255));
        pauseButton.setBackground(new Color(0, 128, 0, 255));
        pauseButton.setOpaque(true);
        pauseButton.setFocusPainted(false);
        gridConstraints = new GridBagConstraints();
        gridConstraints.gridx = 2;
        gridConstraints.gridy = 1;
        gridConstraints.gridwidth = 2;
        gridConstraints.insets = new Insets(5, 5, 0, 0);
        gridConstraints.anchor = GridBagConstraints.CENTER;
        timerPanel.add(pauseButton, gridConstraints);
        pauseButton.addActionListener(new ActionListener() {
            public void actionPerformed(ActionEvent e) {
                pauseButtonActionPerformed(e);
            }
        });

        clockPane.add("Timer", timerPanel);

        clockTimer = new Timer(1000, new ActionListener() {
            public void actionPerformed(ActionEvent e) {
                clockTimerActionPerformed(e);
            }
        });

        stopwatchTimer = new Timer(0, new ActionListener() {
            public void actionPerformed(ActionEvent e) {
                stopwatchTimerActionPerformed(e);
            }
        });

        timerTimer = new Timer(0, new ActionListener() {
            public void actionPerformed(ActionEvent e) {
                timerTimerActionPerformed(e);
            }
        });

        clockTimer.start();

        lapList.setModel(lapListModel);
    }

    private void clockTimerActionPerformed(ActionEvent e) {
        Calendar rightNow = Calendar.getInstance();
        int day = rightNow.get(Calendar.DAY_OF_WEEK);
        int month = rightNow.get(Calendar.MONTH);
        int date = rightNow.get(Calendar.DATE);
        int year = rightNow.get(Calendar.YEAR);

        int ampm = rightNow.get(Calendar.AM_PM);
        int hour = rightNow.get(Calendar.HOUR);
        int minute = rightNow.get(Calendar.MINUTE);
        int second = rightNow.get(Calendar.SECOND);

        dayLabel.setText(dayString[day] + ",");
        dateLabel.setText(monthString[month] + " " + date + ", " + year);
        clockLabel.setText(hour + ":" + numberFormat.format(minute) + ":" + numberFormat.format(second) + " " + ampmString[ampm]);
    }

    private void startButtonActionPerformed(ActionEvent e) {
        if (startButton.getText().equals("Start")) {
            if (stopwatchElapsedLabel.getText().equals("00:00:00.00")) {
                lapButton.setEnabled(true);
                lapListModel.addElement("Lap 1  00:00:00.00");
                stopwatchStartTime = System.currentTimeMillis();
            } else {
                stopwatchStartTime += (System.currentTimeMillis() - stopwatchPausedTime);
            }
            stopwatchTimer.start();
            startButton.setText("Stop");
            startButton.setForeground(new Color(255, 0, 0, 255));
            startButton.setBackground(new Color(128, 0, 0, 255));
            lapButton.setText("Lap");
        } else if (startButton.getText().equals("Stop")) {
            stopwatchPausedTime = System.currentTimeMillis();
            stopwatchTimer.stop();
            startButton.setText("Start");
            startButton.setForeground(new Color(0, 200, 0, 255));
            startButton.setBackground(new Color(0, 128, 0, 255));
            lapButton.setText("Reset");
        }
    }

    private void lapButtonActionPerformed(ActionEvent e) {
        if (lapButton.getText().equals("Reset")) {
            stopwatchTimer.stop();
            stopwatchElapsedLabel.setText("00:00:00.00");
            startButton.setText("Start");
            lapButton.setText("Lap");
            lapButton.setEnabled(false);
            startButton.setForeground(new Color(0, 200, 0, 255));
            startButton.setBackground(new Color(0, 128, 0, 255));
            stopwatchElapsedTime = 00;
            stopwatchHundreds = 00;
            stopwatchSeconds = 00;
            stopwatchMinutes = 00;
            stopwatchHours = 00;
            lapListModel.clear();
        } else if (lapButton.getText().equals("Lap")) {
            lapListModel.add(0, "Lap " + lapListModel.getSize() + 1 + "  " + stopwatchElapsedLabel.getText());
        }

    }

    private void stopwatchTimerActionPerformed(ActionEvent e) {
        stopwatchElapsedTime = (int) (System.currentTimeMillis() - stopwatchStartTime);
        stopwatchHours = stopwatchElapsedTime / 3600000;
        stopwatchElapsedTime -= stopwatchHours * 3600000;
        stopwatchMinutes = stopwatchElapsedTime / 60000;
        stopwatchElapsedTime -= stopwatchMinutes * 60000;
        stopwatchSeconds = stopwatchElapsedTime / 1000;
        stopwatchElapsedTime -= stopwatchSeconds * 1000;
        stopwatchHundreds = stopwatchElapsedTime / 10;
        stopwatchElapsedLabel.setText(numberFormat.format(stopwatchHours) + ":" + numberFormat.format(stopwatchMinutes) + ":" + numberFormat.format(stopwatchSeconds) + "." + numberFormat.format(stopwatchHundreds));
        lapListModel.set(0, "Lap " + lapListModel.getSize() + "  " + stopwatchElapsedLabel.getText());
    }

    private void cancelButtonActionPerformed(ActionEvent e) {
        pauseButton.setText("Start");
        pauseButton.setForeground(new Color(0, 200, 0, 255));
        pauseButton.setBackground(new Color(0, 128, 0, 255));
        cancelButton.setEnabled(false);
        timerLabel.setVisible(false);
        hourSpinner.setVisible(true);
        hourLabel.setVisible(true);
        minuteSpinner.setVisible(true);
        minuteLabel.setVisible(true);
        timerLabel.setText("00:00.00");
        timerTimer.stop();
        timerTimer = new Timer(0, new ActionListener() {
            public void actionPerformed(ActionEvent e) {
                timerTimerActionPerformed(e);
            }
        });
    }

    private void pauseButtonActionPerformed(ActionEvent e) {
        if (pauseButton.getText().equals("Start")) {
            pauseButton.setText("Pause");
            pauseButton.setForeground(new Color(255, 128, 0));
            pauseButton.setBackground(new Color(200, 100, 0));
            cancelButton.setEnabled(true);
            hourSpinner.setVisible(false);
            hourLabel.setVisible(false);
            minuteSpinner.setVisible(false);
            minuteLabel.setVisible(false);
            timerLabel.setVisible(true);
            if (timerLabel.getText().equals("00:00.00")) {
                timerStartTime = System.currentTimeMillis();
                hourValue = Integer.parseInt(hourSpinner.getValue().toString());
                minuteValue = Integer.parseInt(minuteSpinner.getValue().toString());
            } else {
                timerStartTime += (System.currentTimeMillis() - timerPausedTime);
            }
            timerTimer.start();
        } else if (pauseButton.getText().equals("Pause")) {
            pauseButton.setText("Start");
            pauseButton.setForeground(new Color(0, 200, 0, 255));
            pauseButton.setBackground(new Color(0, 128, 0, 255));
            timerPausedTime = System.currentTimeMillis();
            timerTimer.stop();
        }
    }

    private void spinnerStateChanged(ChangeEvent e) {
        hourValue = Integer.parseInt(hourSpinner.getValue().toString());
        minuteValue = Integer.parseInt(minuteSpinner.getValue().toString());
        if (minuteValue == 60 && hourValue != 0) {
            minuteSpinner.setValue(0);
        } else if (minuteValue == -1) {
            minuteSpinner.setValue(59);
        }
        if (hourValue == 0 && minuteValue == 0) {
            minuteSpinner.setValue(59);
        } else if (hourValue == 0 && minuteValue == 60) {
            minuteSpinner.setValue(1);
        }

        if (hourValue == 1) {
            hourLabel.setText("hour");
        } else {
            hourLabel.setText("hours");
        }
        hourValue = Integer.parseInt(hourSpinner.getValue().toString());
        minuteValue = Integer.parseInt(minuteSpinner.getValue().toString());
    }

    private void timerTimerActionPerformed(ActionEvent e) {
        timerElapsedTime = (int) (System.currentTimeMillis() - timerStartTime);
        timerElapsedTime = ((hourValue * 3600000) + (minuteValue * 60000)) - timerElapsedTime;
        timerHours = timerElapsedTime / 3600000;
        timerElapsedTime -= timerHours * 3600000;
        timerMinutes = timerElapsedTime / 60000;
        timerElapsedTime -= timerMinutes * 60000;
        timerSeconds = timerElapsedTime / 1000;
        timerElapsedTime -= timerSeconds * 1000;
        timerHundreds = timerElapsedTime / 10;
        if (timerMinutes <= 0 && timerHours <= 0) {
            timerLabel.setText(numberFormat.format(timerSeconds) + "." + numberFormat.format(timerHundreds));
        } else if (timerHours <= 0) {
            timerLabel.setText(numberFormat.format(timerMinutes) + ":" + numberFormat.format(timerSeconds) + "." + numberFormat.format(timerHundreds));
        } else if (timerHours > 0) {
            timerLabel.setText(numberFormat.format(timerHours) + ":" + numberFormat.format(timerMinutes) + ":" + numberFormat.format(timerSeconds) + "." + numberFormat.format(timerHundreds));
        }
        if (timerSeconds <= 0 && timerHundreds <= 0) {
            cancelButton.doClick();
            Toolkit.getDefaultToolkit().beep();
            Timer beepTimer = new Timer(3500, new ActionListener() {
                public void actionPerformed(ActionEvent e) {
                    Toolkit.getDefaultToolkit().beep();
                }
            });
            beepTimer.start();
            JOptionPane.showMessageDialog(null, "Timer Done", "Timer", JOptionPane.PLAIN_MESSAGE);
            beepTimer.stop();
        }
    }
}

danpost

2017/4/20

I would try inserting the following at line 479:

boolean timeElapsed = timerElapsedTime <= 0;

and changing line 493 to:

if (timeElapsed)

Yehuda

2017/4/21

I can't really tell if it's fixed, since it doesn't always happen anyway but thanks. If it happens again then I'll say so.

Yehuda

2017/4/21

The first time the scenario is run all the components pop up with the Java Look and Feel, when I press "Reset" another frame pops up with the Look and Feel that I set it to. Is there any way that I can get one set of components to exist and with the proper Look and Feel? You can see here that even though I set the world to be 200x260, on the uploaded version of my scenario the width is doubled. Since it was bigger I was the double set of components, when I made the world a little bigger on my regular version of the scenario I saw a little bit of the second set of components also.

Yehuda

2017/4/21

I think that the only problem now is the uploaded frame being double the width of my JPanel instead of being what I specified it to be.

Wasupmacuz

2017/4/21

First, a question for the team, is there a minimum size for uploaded worlds? If so, this could be the issue.

danpost

2017/4/21

Wasupmacuz wrote...

First, a question for the team, is there a minimum size for uploaded worlds? If so, this could be the issue.

I think the minimum size for uploading a scenario is 1 pixel by 1 pixel. The width of the frame in which an uploaded scenario is placed, however, is limited by the GUI control frame below the scenario. The scenario itself is still whatever size you made it. It only looks bigger because the background is white and blends into scenarios with white backgrounds. I would think that there should be a frame around the scenario itself, though -- which seems to be missing when the scenario window is smaller than the minimum GUI width.

You need to login to post a reply.

Greenfoot

Activity

About

Documentation

Download

Discuss

Scenarios

Timer Done