This site requires JavaScript, please enable it in your browser!
Greenfoot back
Hondrok
Hondrok wrote ...

2017/2/8

Jumping animation problem

Hondrok Hondrok

2017/2/8

#
I'm trying to change the actor's image while jumping when the moving images are facing the left side (fr0m, fr1m...fr6m, m stands for mirror) line 108
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
import greenfoot.*;
    
public class Mario extends Actor
{
    private int speed = 6;
    private int vSpeed = 0;
    private int acceleration = 2;
    private int jumpStrength = 25;
    public int armour = 3;
     
    private int frame = 0;
    private int attFrame = 0;
     
    private int animationCounter = 0;
     
    private GreenfootImage fr0 = new GreenfootImage("Mario_fr0.png");
    private GreenfootImage fr1 = new GreenfootImage("Mario_fr1.png");
    private GreenfootImage fr2 = new GreenfootImage("Mario_fr2.png");
    private GreenfootImage fr3 = new GreenfootImage("Mario_fr3.png");
    private GreenfootImage fr4 = new GreenfootImage("Mario_fr4.png");
    private GreenfootImage fr5 = new GreenfootImage("Mario_fr5.png");
    private GreenfootImage fr6 = new GreenfootImage("Mario_fr6.png");
     
    private GreenfootImage fr0m = new GreenfootImage("Mario_fr0m.png");
    private GreenfootImage fr1m = new GreenfootImage("Mario_fr1m.png");
    private GreenfootImage fr2m = new GreenfootImage("Mario_fr2m.png");
    private GreenfootImage fr3m = new GreenfootImage("Mario_fr3m.png");
    private GreenfootImage fr4m = new GreenfootImage("Mario_fr4m.png");
    private GreenfootImage fr5m = new GreenfootImage("Mario_fr5m.png");
    private GreenfootImage fr6m = new GreenfootImage("Mario_fr6m.png");
     
    private GreenfootImage att_fr0m = new GreenfootImage("Mario_att_fr0m.png");
    private GreenfootImage att_fr1m = new GreenfootImage("Mario_att_fr1m.png");
    private GreenfootImage att_fr2m = new GreenfootImage("Mario_att_fr2m.png");
     
    private GreenfootImage att_fr0 = new GreenfootImage("Mario_att_fr0.png");
    private GreenfootImage att_fr1 = new GreenfootImage("Mario_att_fr1.png");
    private GreenfootImage att_fr2 = new GreenfootImage("Mario_att_fr2.png");
      
    public void act()
    {
       if (! getWorld().getObjects(GameOver.class).isEmpty())
       {
           return;
       }     
       checkKeys();
       attack();
       checkFall();
       hitGoomba();
       hitCastle_l1();
       hitCastle_l2();
       checkArmour();
       animationCounter ++;
       jumpAnimation();
    }
     
    private void checkKeys() 
    {
       if(Greenfoot.isKeyDown("left"))
       {
           moveLeft();
       }
        
       if(Greenfoot.isKeyDown("right"))
       {
           moveRight();
       }
        
       if(Greenfoot.isKeyDown("up"))
       {
           jump();
       }
    }   
  
    public void checkFall()
    {
        if(onGround() && vSpeed != -jumpStrength)
        {
           vSpeed=0;
        }
        else
        {
            setImage("Mario_fr0.png");
            fall();
        }
    }
      
    public boolean onGround()
    {
        Actor under = getOneObjectAtOffset ( 0, getImage().getHeight()/2, Ground.class);
        return under != null;
    }
      
    public void fall()
    {
        setLocation ( getX(), getY() + vSpeed);
        vSpeed = vSpeed + acceleration;
    }  
          
    public void jump()
    {
       if (onGround())
       {
           vSpeed = - jumpStrength;
       }
    }
          
    public void jumpAnimation()
    {
        if ((getImage().equals(fr0m) ||
             getImage().equals(fr1m) ||
             getImage().equals(fr2m) ||
             getImage().equals(fr3m) ||
             getImage().equals(fr4m) ||
             getImage().equals(fr5m) ||
             getImage().equals(fr6m)) &&
             Greenfoot.isKeyDown("up")
            )
        {
            setImage(fr2m);
        }
    }
     
    public void moveRight()
    {
        setLocation ( getX() + speed, getY());
         
        if(animationCounter % 4 == 0)
        {
            animateRight();
        }
    }
     
    public void animateRight()
    {
        if(frame == 0)
        {
            setImage(fr0);
        }
        else if(frame == 1)
        {
            setImage(fr1);
        }
        else if(frame == 2)
        {
            setImage(fr2);
        }
        else if(frame == 3)
        {
            setImage(fr3);
        }
        else if(frame == 4)
        {
            setImage(fr4);
        }
        else if(frame == 5)
        {
            setImage(fr5);
        }
        else if(frame == 6)
        {
            setImage(fr6);
            frame = 1;
            return;
        }
         
        frame++;
    }
      
    public void moveLeft()
    {
        setLocation ( getX() - speed, getY());
         
        if(animationCounter % 4 == 0)
        {
            animateLeft();
        }
    }
     
    public void animateLeft()
    {
        if(frame == 0)
        {
            setImage(fr0m);
        }
        else if(frame == 1)
        {
            setImage(fr1m);
        }
        else if(frame == 2)
        {
            setImage(fr2m);
        }
        else if(frame == 3)
        {
            setImage(fr3m);
        }
        else if(frame == 4)
        {
            setImage(fr4m);
        }
        else if(frame == 5)
        {
            setImage(fr5m);
        }
        else if(frame == 6)
        {
            setImage(fr6m);
            frame = 1;
            return;
        }
 
        frame++;
    }
 
    public void attack()
    {
        if(Greenfoot.isKeyDown("space"))
        {
            if (animationCounter % 4 == 0)
            {
                animateAttack();
            }
        }
    }
 
    public void animateAttack()
    {
        if(attFrame == 0)
        {
            setImage(att_fr0);
        }
        else if(attFrame == 1)
        {
            setImage(att_fr1);
            getWorld().addObject(new Sphere_right(), getX() + 6, getY()-50);
        }
        else if(attFrame == 2)
        {
            setImage(att_fr2);
            attFrame = 0;
            return;
        }
         
        attFrame++;
    }
     
    public void checkArmour()
    {
        Actor sphere = getOneIntersectingObject(Sphere_left.class);
         
        if(sphere != null)
        {
           armour = armour - 1;
           ((Health_Bar) getWorld().getObjects(Health_Bar.class).get(0)).updateImage(armour);
           getWorld().removeObject(sphere);
        }
         
        if(armour == 0)
        {
            getImage().setTransparency(0);
            World world = new Game_Over_Lose();
            Greenfoot.setWorld(world);
        }
    }
     
    public void hitGoomba()
    {
        Actor goomba = getOneIntersectingObject(Goomba.class);
         
        if(goomba != null)
        {
            armour = armour - 1;
            getWorld().removeObject(goomba);
            ((Health_Bar) getWorld().getObjects(Health_Bar.class).get(0)).updateImage(armour);
        }
    }
      
    public void hitCastle_l1()
    {
        Actor castle = getOneIntersectingObject(Castle.class);
         
        if(castle != null)
        {
            World world = new Level_2();
            Mario mario2 = (Mario)world.getObjects(Mario.class).get(0);
            mario2.armour = this.armour;
            Greenfoot.setWorld(world);
            ((Health_Bar)world.getObjects(Health_Bar.class).get(0)).updateImage(armour);
        }
    }
     
    public void hitCastle_l2()
    {
        Actor castle = getOneIntersectingObject(Castle_l2.class);
         
        if(castle != null)
        {
            World world = new Final_level();
            Mario mario3 = (Mario)world.getObjects(Mario.class).get(0);
            mario3.armour = this.armour;
            Greenfoot.setWorld(world);
            ((Health_Bar)world.getObjects(Health_Bar.class).get(0)).updateImage(armour);
        }
    }
}
danpost danpost

2017/2/8

#
I think you can call 'jumpAnimation' at line 83 instead of setting a right walking (or idle) image there. You need an 'else if' in the jumpAnimation method for non-'m' images as well.
Hondrok Hondrok

2017/2/8

#
danpost wrote...
I think you can call 'jumpAnimation' at line 83 instead of setting a right walking (or idle) image there. You need an 'else if' in the jumpAnimation method for non-'m' images as well.
Still not working import greenfoot.*;
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
public class Mario extends Actor
{
    private int speed = 6;
    private int vSpeed = 0;
    private int acceleration = 2;
    private int jumpStrength = 25;
    public int armour = 3;
     
    private int frame = 0;
    private int attFrame = 0;
     
    private int animationCounter = 0;
     
    private GreenfootImage fr0 = new GreenfootImage("Mario_fr0.png");
    private GreenfootImage fr1 = new GreenfootImage("Mario_fr1.png");
    private GreenfootImage fr2 = new GreenfootImage("Mario_fr2.png");
    private GreenfootImage fr3 = new GreenfootImage("Mario_fr3.png");
    private GreenfootImage fr4 = new GreenfootImage("Mario_fr4.png");
    private GreenfootImage fr5 = new GreenfootImage("Mario_fr5.png");
    private GreenfootImage fr6 = new GreenfootImage("Mario_fr6.png");
     
    private GreenfootImage fr0m = new GreenfootImage("Mario_fr0m.png");
    private GreenfootImage fr1m = new GreenfootImage("Mario_fr1m.png");
    private GreenfootImage fr2m = new GreenfootImage("Mario_fr2m.png");
    private GreenfootImage fr3m = new GreenfootImage("Mario_fr3m.png");
    private GreenfootImage fr4m = new GreenfootImage("Mario_fr4m.png");
    private GreenfootImage fr5m = new GreenfootImage("Mario_fr5m.png");
    private GreenfootImage fr6m = new GreenfootImage("Mario_fr6m.png");
     
    private GreenfootImage att_fr0m = new GreenfootImage("Mario_att_fr0m.png");
    private GreenfootImage att_fr1m = new GreenfootImage("Mario_att_fr1m.png");
    private GreenfootImage att_fr2m = new GreenfootImage("Mario_att_fr2m.png");
     
    private GreenfootImage att_fr0 = new GreenfootImage("Mario_att_fr0.png");
    private GreenfootImage att_fr1 = new GreenfootImage("Mario_att_fr1.png");
    private GreenfootImage att_fr2 = new GreenfootImage("Mario_att_fr2.png");
      
    public void act()
    {
       if (! getWorld().getObjects(GameOver.class).isEmpty())
       {
           return;
       }     
       checkKeys();
       attack();
       checkFall();
       hitGoomba();
       hitCastle_l1();
       hitCastle_l2();
       checkArmour();
       animationCounter ++;
       jumpAnimation();
    }
     
    private void checkKeys() 
    {
       if(Greenfoot.isKeyDown("left"))
       {
           moveLeft();
       }
        
       if(Greenfoot.isKeyDown("right"))
       {
           moveRight();
       }
        
       if(Greenfoot.isKeyDown("up"))
       {
           jump();
       }
    }   
  
    public void checkFall()
    {
        if(onGround() && vSpeed != -jumpStrength)
        {
           vSpeed=0;
        }
        else
        {
            setImage("Mario_fr0.png");
            fall();
            jumpAnimation();
        }
    }
      
    public boolean onGround()
    {
        Actor under = getOneObjectAtOffset ( 0, getImage().getHeight()/2, Ground.class);
        return under != null;
    }
      
    public void fall()
    {
        setLocation ( getX(), getY() + vSpeed);
        vSpeed = vSpeed + acceleration;
    }  
          
    public void jump()
    {
       if (onGround())
       {
           vSpeed = - jumpStrength;
       }
    }
          
    public void jumpAnimation()
    {
        if ((getImage().equals(fr0m) ||
             getImage().equals(fr1m) ||
             getImage().equals(fr2m) ||
             getImage().equals(fr3m) ||
             getImage().equals(fr4m) ||
             getImage().equals(fr5m) ||
             getImage().equals(fr6m)) &&
             Greenfoot.isKeyDown("up")
            )
        {
            setImage(fr2m);
        }
    }
     
    public void moveRight()
    {
        setLocation ( getX() + speed, getY());
         
        if(animationCounter % 4 == 0)
        {
            animateRight();
        }
    }
     
    public void animateRight()
    {
        if(frame == 0)
        {
            setImage(fr0);
        }
        else if(frame == 1)
        {
            setImage(fr1);
        }
        else if(frame == 2)
        {
            setImage(fr2);
        }
        else if(frame == 3)
        {
            setImage(fr3);
        }
        else if(frame == 4)
        {
            setImage(fr4);
        }
        else if(frame == 5)
        {
            setImage(fr5);
        }
        else if(frame == 6)
        {
            setImage(fr6);
            frame = 1;
            return;
        }
         
        frame++;
    }
      
    public void moveLeft()
    {
        setLocation ( getX() - speed, getY());
         
        if(animationCounter % 4 == 0)
        {
            animateLeft();
        }
    }
     
    public void animateLeft()
    {
        if(frame == 0)
        {
            setImage(fr0m);
        }
        else if(frame == 1)
        {
            setImage(fr1m);
        }
        else if(frame == 2)
        {
            setImage(fr2m);
        }
        else if(frame == 3)
        {
            setImage(fr3m);
        }
        else if(frame == 4)
        {
            setImage(fr4m);
        }
        else if(frame == 5)
        {
            setImage(fr5m);
        }
        else if(frame == 6)
        {
            setImage(fr6m);
            frame = 1;
            return;
        }
 
        frame++;
    }
 
    public void attack()
    {
        if(Greenfoot.isKeyDown("space"))
        {
            if (animationCounter % 4 == 0)
            {
                animateAttack();
            }
        }
    }
 
    public void animateAttack()
    {
        if(attFrame == 0)
        {
            setImage(att_fr0);
        }
        else if(attFrame == 1)
        {
            setImage(att_fr1);
            getWorld().addObject(new Sphere_right(), getX() + 6, getY()-50);
        }
        else if(attFrame == 2)
        {
            setImage(att_fr2);
            attFrame = 0;
            return;
        }
         
        attFrame++;
    }
     
    public void checkArmour()
    {
        Actor sphere = getOneIntersectingObject(Sphere_left.class);
         
        if(sphere != null)
        {
           armour = armour - 1;
           ((Health_Bar) getWorld().getObjects(Health_Bar.class).get(0)).updateImage(armour);
           getWorld().removeObject(sphere);
        }
         
        if(armour == 0)
        {
            getImage().setTransparency(0);
            World world = new Game_Over_Lose();
            Greenfoot.setWorld(world);
        }
    }
     
    public void hitGoomba()
    {
        Actor goomba = getOneIntersectingObject(Goomba.class);
         
        if(goomba != null)
        {
            armour = armour - 1;
            getWorld().removeObject(goomba);
            ((Health_Bar) getWorld().getObjects(Health_Bar.class).get(0)).updateImage(armour);
        }
    }
      
    public void hitCastle_l1()
    {
        Actor castle = getOneIntersectingObject(Castle.class);
         
        if(castle != null)
        {
            World world = new Level_2();
            Mario mario2 = (Mario)world.getObjects(Mario.class).get(0);
            mario2.armour = this.armour;
            Greenfoot.setWorld(world);
            ((Health_Bar)world.getObjects(Health_Bar.class).get(0)).updateImage(armour);
        }
    }
     
    public void hitCastle_l2()
    {
        Actor castle = getOneIntersectingObject(Castle_l2.class);
         
        if(castle != null)
        {
            World world = new Final_level();
            Mario mario3 = (Mario)world.getObjects(Mario.class).get(0);
            mario3.armour = this.armour;
            Greenfoot.setWorld(world);
            ((Health_Bar)world.getObjects(Health_Bar.class).get(0)).updateImage(armour);
        }
    }
}
danpost danpost

2017/2/8

#
Hondrok wrote...
Still not working
Remove line 81 in your last code post. Remove '&&' at the end of line 115 and remove line 116. Insert between lines 120 and 121, an 'else if' clause and repeat what is above it for right facing images.
Hondrok Hondrok

2017/2/8

#
danpost wrote...
Hondrok wrote...
Still not working
Remove line 81 in your last code post. Remove '&&' at the end of line 115 and remove line 116. Insert between lines 120 and 121, an 'else if' clause and repeat what is above it for right facing images.
it wooorks thank you a loooot dan
You need to login to post a reply.